Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Putting ballots in separate memory #121

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Putting ballots in separate memory #121

merged 2 commits into from
Mar 1, 2024

Conversation

ineiti
Copy link
Member

@ineiti ineiti commented Feb 16, 2024 •
edited
Loading

This PR separates the ballots from the forms.
This allows to run adding a new ballot much faster. When there are more than 100 ballots, this gets very important: adding a 1000th ballot can take 1s, a 10'000th ballot 10s.

Using this PR, up to the 10'000th ballot it only takes 100ms.

Thank you for opening a pull request with this project, please also:

  • add a brief description of your changes here
  • assign the PR to yourself, or to the person(s) working on it
  • start in draft mode and in progress pipeline in the project (if applicable)
  • if applicable, add this PR to its related issue by one of the special keywords Closing keywords
  • once it's ready
    • put it in the Review or Ready4Merge pipeline in the project (if applicable)
    • remove draft
    • assign a reviewer

@ineiti ineiti self-assigned this Feb 16, 2024
@ineiti ineiti mentioned this pull request Feb 16, 2024
Closed
7 tasks
@ineiti ineiti force-pushed the separate_ballots branch 4 times, most recently from 0bf9ab6 to 7804ac7 Compare February 28, 2024 09:02
@ineiti
Putting ballots in separate memory
889e22b 
This PR separates the ballots from the forms.
This allows to run adding a new ballot much faster.
When there are more than 100 ballots, this gets very important:
adding a 1000th ballot can take 1s, a 10'000th ballot 10s.

Using this PR, up to the 10'000th ballot it only takes 100ms.
@ineiti ineiti force-pushed the separate_ballots branch 5 times, most recently from 3cdb746 to c9b8a2f Compare February 28, 2024 15:29
@ineiti ineiti requested a review from PascalinDe February 28, 2024 15:58
@ineiti ineiti marked this pull request as ready for review February 29, 2024 15:29
PascalinDe
PascalinDe requested changes Mar 1, 2024
View reviewed changes
Copy link
Member

@PascalinDe PascalinDe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tests/json/evoting/forms/openNoVotes.json got into the mix by mistake, have you rebased your branch on the current main?

@ineiti ineiti force-pushed the separate_ballots branch from c9b8a2f to 76d53c1 Compare March 1, 2024 12:04
@ineiti
Copy link
Member Author

ineiti commented Mar 1, 2024

I think the tests/json/evoting/forms/openNoVotes.json got into the mix by mistake, have you rebased your branch on the current main?

True - late night git issue debugging. I was confused where this file comes from and was under the impression it was in the latest main... Deleted now.

@ineiti ineiti merged commit d34d817 into main Mar 1, 2024
11 checks passed
@ineiti ineiti deleted the separate_ballots branch March 1, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalinDe PascalinDe PascalinDe approved these changes

Assignees

@ineiti ineiti

Labels
None yet
Projects
D-Voting
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ineiti @PascalinDe